Coins deprecation #16131

MiroslavProchazka · 2025-01-02T08:13:32Z

As of February 2025, Trezor Suite will discontinue support for Dash, Bitcoin Gold, DigiByte, Namecoin, and Vertcoin. Users are advised to migrate their funds to alternative wallets to ensure continued access and security. The coins will still be supported on the FW level, so users can still access them using third party wallets.

Proposed Timeline:

February Suite Release: This version of Suite will no longer support the affected coins. However, users can still use older versions of Suite to access their coins.
July 2025: The BEs will be turned off. From this point forward, third-party apps will be the only way to access the coins.

I will divide the commits by environment (desktop/native) to make code review easier.

Please read the following before conducting the code review:

Since the coins will still be supported by the firmware and third-party apps, we should maintain support at the Connect level. Similarly, we will continue support in blockchain-link and utxo-lib.
For now, we have decided to keep these coins in Trading (users will need to use external addresses for this), so we need to retain the Address Validator as well.
We need to create a migration for users with remembered wallets.

Given the points above, I have prepared only basic deprecation that mainly affects NetworksConfig. Everything else (tests, icons, etc.) will remain unchanged until we decide to disable trading options and/or turn off the backends.

Todo:

In case that the coins will be still available for trading (to external wallets), can we delete their icons, names in messages.ts and other mentions in general files?
Should I also delete all tests mentioning those coins?
As some of the coins files needs to stay in the codespace (address validator, blockchain-link, connect etc.), it would be wise to determinate minimal scope for just Suite deprecation - will this be just NetworksConfig?
Adjust coins.ts
Adjust /trezor-suite/suite-common/suite-constants/src/protocol.ts
Create migration for users with remembered wallet - Suite
Create migration for users with remembered wallet - Suite lite
Create migration for migrateEnabledDiscoveryNetworkSymbols - discovery

This pull request includes significant changes related to the removal of support for several cryptocurrencies across multiple files. The most important changes include updating the LegacyNetworkSymbol type, modifying protocol definitions, and removing network configurations and symbols.

Removal of support for specific cryptocurrencies:

packages/product-components/src/components/CoinLogo/coins.ts: Updated LegacyNetworkSymbol to include additional unsupported coins.
suite-common/suite-constants/src/protocol.ts: Removed protocols for bitcoingold, dash, digibyte, namecoin, and vertcoin. [1] [2]
suite-common/wallet-config/src/networksConfig.ts: Removed network configurations for dash, btg, dgb, nmc, and vtc.
suite-common/wallet-config/src/types.ts: Updated NetworkSymbol to remove symbols for btg, dash, dgb, nmc, and vtc.
suite-native/config/src/supportedNetworks.ts: Updated the whitelist and removed the blacklist for unsupported coins. [1] [2]

github-actions · 2025-01-02T08:17:41Z

🚀 Expo preview is ready!

Project → trezor-suite-preview
Platforms → android, ios
Scheme → trezorsuitelite
Runtime Version → 23
More info

Learn more about 𝝠 Expo Github Action

vytick · 2025-01-02T14:21:04Z

suite-native/config/src/supportedNetworks.ts

@@ -78,9 +58,7 @@ export const filterBlacklistedNetworks = (
    );

 export const portfolioTrackerMainnets = sortNetworks(


If I see correctly, if we remove the portfolio blacklist, we can remove portfolioTrackerMainnets and getPortfolioTrackerTestnets completely and use networkSymbolsWhitelistMap.mainnets and networkSymbolsWhitelistMap.testnets instead, wdyt?

We need to create issue for this

In here - #16683

vytick · 2025-01-02T14:21:23Z

suite-native/storage/src/migrations/account/v3.ts

@@ -18,12 +18,7 @@ type NetworkSymbol =
    | 'etc'
    | 'xrp'
    | 'bch'
-    | 'btg'


I think we should keep those in this migration

yes. maybe there should be migration removing target deprecated coins accounts from state as well. but its not that big deal. it can stay there forever and nothing will probably ever happen

I will prepare migration for users with remembered wallet.

marekrjpolak

Apart from mentioned, it looks good (= same as e.g. tgor deprecation).

suite-common/suite-constants/src/protocol.ts

packages/suite/src/storage/migrations/index.ts

suite-native/config/src/supportedNetworks.ts

MiroslavProchazka · 2025-01-25T22:18:57Z

You forgot to remove icons from suite-common/icons, suite-common/icons-deprecated packages

As this affects additional files and tests and it is not necessary for the deprecation, I will leave it for later cleanup together with BE deprecation of these coins

chore(suite-native): basic deprecation on suite lite level

packages/suite/src/storage/migrations/index.ts

suite-native/storage/src/migrations/discovery/v3.ts

vytick

Good job 👍. I have tested it and it works as expected 🦾 .

Please, create issue for redundant portfolioTrackerMainnets and remove that log as you discussed in comments

chore(suite): add migration for deprecated coins

matejkriz

Good job 👏 The only issue is that you don't remove enough coins, I would delete a few more 😉

One nitpick is that there is missing migration for graph state (we stored the preferred time range per coin), but it's not deleted properly even if you just disable any coin, so I would keep it as it is. It is quite hard to filter those and it's just a small data, most users will not have it anyway...)

Works as expected, I was checking the redux state after migration from develop to this branch.

MiroslavProchazka changed the title ~~chore(suite): basic deprecation on suite level~~ Coins deprecation (WIP) Jan 2, 2025

MiroslavProchazka mentioned this pull request Jan 2, 2025

(WIP) Coins deprecation #15509

Closed

6 tasks

MiroslavProchazka requested a review from tomasklim January 2, 2025 08:19

MiroslavProchazka force-pushed the chore/coins-deprecation branch from 3e2ce44 to 2a3c207 Compare January 2, 2025 08:49

MiroslavProchazka requested a review from komret January 2, 2025 09:55

vytick reviewed Jan 2, 2025

View reviewed changes

MiroslavProchazka force-pushed the chore/coins-deprecation branch from 2a3c207 to 4bdc0ac Compare January 3, 2025 08:36

MiroslavProchazka requested a review from a team January 3, 2025 13:58

MiroslavProchazka force-pushed the chore/coins-deprecation branch 6 times, most recently from 50973b7 to 0405953 Compare January 9, 2025 15:41

MiroslavProchazka marked this pull request as ready for review January 9, 2025 15:42

MiroslavProchazka requested review from Nodonisko, jvaclavik, adamhavel and a team as code owners January 9, 2025 15:42

MiroslavProchazka force-pushed the chore/coins-deprecation branch 4 times, most recently from 22960bc to bd9da1f Compare January 9, 2025 16:01

MiroslavProchazka changed the title ~~Coins deprecation (WIP)~~ Coins deprecation Jan 9, 2025

MiroslavProchazka force-pushed the chore/coins-deprecation branch from bd9da1f to 53e914c Compare January 9, 2025 19:11

MiroslavProchazka requested review from matejkriz and marekrjpolak January 9, 2025 19:13

marekrjpolak approved these changes Jan 10, 2025

View reviewed changes

suite-common/suite-constants/src/protocol.ts Show resolved Hide resolved

packages/suite/src/storage/migrations/index.ts Show resolved Hide resolved

HajekOndrej approved these changes Jan 10, 2025

View reviewed changes

tomasklim reviewed Jan 14, 2025

View reviewed changes

packages/suite/src/storage/migrations/index.ts Show resolved Hide resolved

MiroslavProchazka force-pushed the chore/coins-deprecation branch from 53e914c to 2cb1f13 Compare January 15, 2025 15:59

MiroslavProchazka commented Jan 15, 2025

View reviewed changes

suite-native/config/src/supportedNetworks.ts Show resolved Hide resolved

MiroslavProchazka commented Jan 15, 2025

View reviewed changes

suite-native/config/src/supportedNetworks.ts Outdated Show resolved Hide resolved

MiroslavProchazka force-pushed the chore/coins-deprecation branch 2 times, most recently from c9c3719 to d76c9c1 Compare January 25, 2025 18:57

chore(suite): basic deprecation on suite level

2fb4a9d

MiroslavProchazka force-pushed the chore/coins-deprecation branch 3 times, most recently from fa490fd to 3aa96f8 Compare January 25, 2025 22:49

chore(suite-native): basic deprecation on suite lite level

8f04ea5

chore(suite-native): basic deprecation on suite lite level

MiroslavProchazka force-pushed the chore/coins-deprecation branch from 3aa96f8 to 7ddc5a4 Compare January 25, 2025 23:04

MiroslavProchazka requested a review from tomasklim January 25, 2025 23:05

tomasklim approved these changes Jan 26, 2025

View reviewed changes

Vere-Grey approved these changes Jan 27, 2025

View reviewed changes

matejkriz reviewed Jan 27, 2025

View reviewed changes

packages/suite/src/storage/migrations/index.ts Outdated Show resolved Hide resolved

matejkriz requested changes Jan 27, 2025

View reviewed changes

suite-native/storage/src/migrations/discovery/v3.ts Show resolved Hide resolved

MiroslavProchazka force-pushed the chore/coins-deprecation branch from 7ddc5a4 to b71ef01 Compare January 27, 2025 15:10

komret approved these changes Jan 27, 2025

View reviewed changes

vytick approved these changes Jan 28, 2025

View reviewed changes

MiroslavProchazka added 3 commits January 28, 2025 16:06

chore(suite): add migration for deprecated coins

0d95d72

chore(suite): add migration for deprecated coins

chore(e2e): adjust e2e test for deprecated coins

ca5d50c

chore(suite-native): add migration for suite-native

666f142

MiroslavProchazka force-pushed the chore/coins-deprecation branch from b71ef01 to 666f142 Compare January 28, 2025 15:06

MiroslavProchazka requested a review from a team as a code owner January 28, 2025 15:06

MiroslavProchazka mentioned this pull request Jan 28, 2025

supportedNetworks.ts cleanup #16683

Open

matejkriz approved these changes Jan 28, 2025

View reviewed changes

vytick merged commit 366cb09 into develop Jan 28, 2025
35 checks passed

vytick deleted the chore/coins-deprecation branch January 28, 2025 18:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Coins deprecation #16131

Coins deprecation #16131

MiroslavProchazka commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

vytick Jan 2, 2025

MiroslavProchazka Jan 27, 2025

MiroslavProchazka Jan 28, 2025

vytick Jan 2, 2025

mroz22 Jan 3, 2025

MiroslavProchazka Jan 3, 2025

MiroslavProchazka Jan 7, 2025

marekrjpolak left a comment

MiroslavProchazka commented Jan 25, 2025 •

edited

Loading

vytick left a comment •

edited

Loading

matejkriz left a comment •

edited

Loading

		@@ -78,9 +58,7 @@ export const filterBlacklistedNetworks = (
		);

		export const portfolioTrackerMainnets = sortNetworks(

@@ @@ -18,12 +18,7 @@ type NetworkSymbol = @@
                   | 'etc'
                   | 'xrp'
                   | 'bch'
-                  | 'btg'

Coins deprecation #16131

Coins deprecation #16131

Conversation

MiroslavProchazka commented Jan 2, 2025 • edited Loading

github-actions bot commented Jan 2, 2025 • edited Loading

vytick Jan 2, 2025

Choose a reason for hiding this comment

MiroslavProchazka Jan 27, 2025

Choose a reason for hiding this comment

MiroslavProchazka Jan 28, 2025

Choose a reason for hiding this comment

vytick Jan 2, 2025

Choose a reason for hiding this comment

mroz22 Jan 3, 2025

Choose a reason for hiding this comment

MiroslavProchazka Jan 3, 2025

Choose a reason for hiding this comment

MiroslavProchazka Jan 7, 2025

Choose a reason for hiding this comment

marekrjpolak left a comment

Choose a reason for hiding this comment

MiroslavProchazka commented Jan 25, 2025 • edited Loading

vytick left a comment • edited Loading

Choose a reason for hiding this comment

matejkriz left a comment • edited Loading

Choose a reason for hiding this comment

MiroslavProchazka commented Jan 2, 2025 •

edited

Loading

github-actions bot commented Jan 2, 2025 •

edited

Loading

MiroslavProchazka commented Jan 25, 2025 •

edited

Loading

vytick left a comment •

edited

Loading

matejkriz left a comment •

edited

Loading